-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flox environment #668
Flox environment #668
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Flox is new to me, AFAICS it seems to built on Nix in some way and easing usage? Looks interesting. I've been using nix/nixos/nix-darwin/home-manager for some time to manage my local dev environments, dotfiles and OS configurations, it was working quite great. That said I've not built the documentation repository locally since quite some time, I don't really feel I should be especially responsible for it and in case it can help I'm fine with every suggestion. We should probably just be sure that it's also aligned with the automatic building via the GitHub Actions, so that the results are the same, including using the same Hugo versions. The GitHub Actions are currently using a pinned version, see https://github.com/EGI-Federation/documentation/blob/2a27cf0e314a54c0abe4766f79bd7c838d96355e/.github/workflows/hugo_version.txt, it's loaded by the actions-hugo, cf documentation/.github/workflows/deploy.yml Lines 27 to 37 in 2a27cf0
So documentation and what is used to built in GA should be all aligned |
This comment has been minimized.
This comment has been minimized.
Thanks for your feedback @gwarf Having both the manual and automated way of creating the environment should help overcome potential disruptions with |
By the way, I am not paying attention to the spelling issues as they are all coming from the config files. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Documentation preview deployed!Available at https://docs.egi.eu/documentation/668 |
Thanks, so the doc site seems to build fine with the new version: https://docs.egi.eu/documentation/668/about/contributing/git/#reuse-the-flox-environment-optional Currently, the flox stuff is a subsection to the installing dep manually, while I think it's more an alternative. |
This comment has been minimized.
This comment has been minimized.
Documentation preview deployed!Available at https://docs.egi.eu/documentation/668 |
This comment has been minimized.
This comment has been minimized.
Documentation preview deployed!Available at https://docs.egi.eu/documentation/668 |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (6)aarch To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:EGI-Federation/documentation.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/EGI-Federation/documentation/actions/runs/10599173978/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (26) from .github/actions/spelling/expect.txt and unrecognized words (6)
Consider adding them (in with:
extra_dictionaries:
cspell:npm/dict/npm.txt
cspell:scala/dict/scala.txt
cspell:filetypes/filetypes.txt
cspell:node/dict/node.txt
cspell:cpp/src/compiler-clang-attributes.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' |
Documentation preview deployed!Available at https://docs.egi.eu/documentation/668 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary
The "version" of docsy that we use is generating the issue described in #639 with the latest versions of
hugo
. According to my tests the latest working version ofhugo
is v0.110.0.In addition to specifying the latest working version of
hugo
in the docs to contribute, I am also adding an environment with flox. See also related discussion in #637.Merging this PR fixes #639. However, we may also want to discuss whether to migrate docsy from git submodules to hugo modules so the latest version of both
hugo
anddocsy
can be used.Related issue : #639