Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust delete PR workflow name and set required permissions #692

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

gwarf
Copy link
Member

@gwarf gwarf commented Jan 9, 2025

I think the deletion of PR preview never works, let's see if we can get it working.

This comment has been minimized.

Copy link

github-actions bot commented Jan 9, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ no-files-to-check 1

See ❌ Event descriptions for more information.

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess we need to test again by merging

@gwarf gwarf merged commit 287c824 into EGI-Federation:main Jan 9, 2025
8 of 9 checks passed
@gwarf gwarf deleted the fix_preview_cleaning branch January 9, 2025 10:28
@gwarf
Copy link
Member Author

gwarf commented Jan 9, 2025

@enolfc it seems to have worked at least when removing the label, I've tried removing it on #664:

@gwarf gwarf mentioned this pull request Jan 9, 2025
@gwarf
Copy link
Member Author

gwarf commented Jan 9, 2025

Hm, there may still be issues, apparently it worked when adding/removing the label but not when merging the PR:

While the workflow file is apparently the same for both run, the permissions logged in the jobs are different:
Screenshot 2025-01-09 at 14 54 32

vs

Screenshot 2025-01-09 at 14 54 42

@gwarf
Copy link
Member Author

gwarf commented Jan 9, 2025

Another different is that the working was for the PR #664, made in a feature branch in this repo while the error is for the PR #685 made in a branch in your fork, which may have an impact on access to secrets.
I will log an issue and stop speaking alone in this closed PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants