Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable spell check workflow on push, only use it in PR #695

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

gwarf
Copy link
Member

@gwarf gwarf commented Jan 9, 2025

There is no real need to spend cycles doing a spell check when pushing to main, especially if there won't be follow up on failures.

This comment has been minimized.

@gwarf
Copy link
Member Author

gwarf commented Jan 9, 2025

I think we could also disable mega-linter that runs on pushes to main, and only keep the actions that are building/deploying to GitHub pages.
Or if we keep something it should create issues/PR on errors.
But for now it's mainly consuming resources for nothing.
What do you think?

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enolfc
Copy link
Contributor

enolfc commented Jan 14, 2025

I think we could also disable mega-linter that runs on pushes to main, and only keep the actions that are building/deploying to GitHub pages. Or if we keep something it should create issues/PR on errors. But for now it's mainly consuming resources for nothing. What do you think?

+1, should we add it here as well?
@brucellino is also reviewing the whole process so I expect more changes in this area soon

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ no-files-to-check 1

See ❌ Event descriptions for more information.

@gwarf
Copy link
Member Author

gwarf commented Jan 14, 2025

I think we could also disable mega-linter that runs on pushes to main, and only keep the actions that are building/deploying to GitHub pages. Or if we keep something it should create issues/PR on errors. But for now it's mainly consuming resources for nothing. What do you think?

+1, should we add it here as well?

I've just updated the conf of mega-linter.

@brucellino is also reviewing the whole process so I expect more changes in this area soon

Great, I'm looking forward to this!

@gwarf gwarf merged commit f421ae9 into EGI-Federation:main Jan 14, 2025
8 of 9 checks passed
@gwarf gwarf deleted the disable_spellcheck_on_push_to_main branch January 14, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants