Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata for orbital parameters in cam_control_mod #325

Merged
merged 11 commits into from
Dec 10, 2024

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Nov 25, 2024

Tag name (required for release branches):
Originator(s): peverwhee

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): Adds metadata for orbital parameters in cam_control_mod.F90

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do:
A src/control/cam_control_mod.meta

  • add metadata file for cam_control_mod.F90

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M .gitmodules

M src/control/cam_control_mod.F90

  • add necessary comments for CCPP parsing

M src/data/registry.xml

  • notify the registry of the new metadata file

M src/physics/units/physics_grid.meta

  • update "radians" to "rad"

M test/unit/sample_files/phys_types_dup_section.meta

  • update "radians" to "rad"

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima: all non-existing failures PASS

derecho/gnu/aux_sima: all non-existing failures PASS

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@peverwhee peverwhee self-assigned this Nov 25, 2024
@peverwhee
Copy link
Collaborator Author

I took a stab at standard names, as there is nothing in the dictionary and we haven't decided on them as a group in the spreadsheet.

Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@peverwhee peverwhee requested a review from nusbaume November 25, 2024 23:55
src/control/cam_control_mod.meta Show resolved Hide resolved
src/control/cam_control_mod.meta Outdated Show resolved Hide resolved
name = cam_control_mod
type = module
[ aqua_planet ]
standard_name = flag_for_aqua_planet_mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A conversation starter for @nusbaume - There is one flag_for standard name and a bunch of do in the standard names repo. An alternate name could be do_aqua_planet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh i like do_aqua_planet better. I've changed it to that, but am happy to hear Jesse's feedback when he returns!

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but did have some (pedantic) change requests, along with a question.

src/control/cam_control_mod.meta Show resolved Hide resolved
src/control/cam_control_mod.meta Outdated Show resolved Hide resolved
src/control/cam_control_mod.meta Outdated Show resolved Hide resolved
src/control/cam_control_mod.meta Outdated Show resolved Hide resolved
src/control/cam_control_mod.meta Outdated Show resolved Hide resolved
src/control/cam_control_mod.meta Outdated Show resolved Hide resolved
src/control/cam_control_mod.meta Outdated Show resolved Hide resolved
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me now, thanks @peverwhee!

@peverwhee peverwhee merged commit d1b20c9 into ESCOMP:development Dec 10, 2024
8 checks passed
mattldawson added a commit to ESCOMP/atmospheric_physics that referenced this pull request Dec 14, 2024
Adds the calculation of solar zenith angle and Earth-Sun distance needed
as inputs to TUV-x.

closes #163 
closes #164 

Both calculations required functions that are currently in shared code
in CAM
[here](https://github.com/ESCOMP/CESM_share/blob/f6f31fd61cb8f80aee97311fcca64b3e26b0202c/src/shr_orb_mod.F90#L736-L814)
and
[here](https://github.com/ESCOMP/CESM_share/blob/f6f31fd61cb8f80aee97311fcca64b3e26b0202c/src/shr_orb_mod.F90#L110-L159)
that I put in a modified form in the `to_be_ccppized/` folder. @nusbaume
@peverwhee - if there is a better way to handle these functions, let me
know and I can update the PR.

Requires an update to CAM-SIMA that is in review to make certain
variables available through CCPP
(ESCOMP/CAM-SIMA#325)

After more discussion, the plan is to use the shared functions in
CAM-SIMA and pass the outputs through CCPP. So, this PR will be put in
draft until this issue is finished:
ESCOMP/CAM-SIMA#328

A related draft PR to CAM-SIMA has been added
(ESCOMP/CAM-SIMA#337) and will be un-drafted
once this PR is merged in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants