Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing ifdef for building without W3_IC4 #33

Open
wants to merge 1 commit into
base: dev/unified
Choose a base branch
from

Conversation

anton-seaice
Copy link

Pull Request Summary

Closes #32

Description

When the improved numerics for IC4 was added, some #ifdef WW3_IC4 statements were replaced with #ifndef W3_IC4_NUMERICS, which is incorrect. The correct line is :

#if defined(W3_IC4) && !defined(W3_IC4_NUMERICS)

So that builds without W3_IC4 are possible

Issue(s) addressed

#32

Commit Message

Add #ifdef W3_IC4 where required to support building without W3_IC4 set

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@anton-seaice
Copy link
Author

ping @dabail10

@anton-seaice
Copy link
Author

Hi @dabail10 - if you have a second to look at this, it would be handy :). I think you just missed a couple of lines when adding the W3_IC4_NUMERICS

@dabail10
Copy link

dabail10 commented Jan 9, 2025

Actually, if you have been following the discussion with the WW3 developers, they want a namelist option for this.

@anton-seaice
Copy link
Author

Ok but for now CESM uses Wavewatch from this dev/unified branch right ?

@dabail10
Copy link

dabail10 commented Jan 9, 2025

Yes, and @alperaltuntas will have to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't compile without W3_IC4 defined
2 participants