Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a config to use global data on CRIB #219

Merged
merged 2 commits into from
Feb 7, 2024
Merged

add a config to use global data on CRIB #219

merged 2 commits into from
Feb 7, 2024

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Feb 2, 2024 •
edited
Loading

Description

related to EcoExtreML/STEMMUS_SCOPE_Processing#93

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review February 6, 2024 10:59
@SarahAlidoost SarahAlidoost mentioned this pull request Feb 6, 2024
Merged
3 tasks
BSchilperoort
BSchilperoort approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK but I did not test it. I don't seem to have access to CRIB anymore.

@SarahAlidoost SarahAlidoost merged commit 0087132 into main Feb 7, 2024
1 check passed
@SarahAlidoost SarahAlidoost deleted the add_config_global branch February 7, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SarahAlidoost @BSchilperoort