Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSM v.0.2: Code changes to activate Groundwater coupling #221

Merged
merged 51 commits into from
Mar 1, 2024
Merged

SSM v.0.2: Code changes to activate Groundwater coupling #221

merged 51 commits into from
Mar 1, 2024

Conversation

MostafaGomaa93
Copy link
Contributor

@MostafaGomaa93 MostafaGomaa93 commented Feb 25, 2024 •
edited by SarahAlidoost
Loading

Description

The description of the changes proposed is in issue 220.

Checklist

  • [✓] Add a reference to related issues -> issue 220..
  • [✓] @mentions of the person for reviewing proposed changes -> @SarahAlidoost and @BSchilperoort.
  • [✓] This pull request has a descriptive title.
  • [✓] Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • [✓] Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@MostafaGomaa93
Update calculateBoundaryConditions.m
3cc79a7
@MostafaGomaa93
Update setBoundaryCondition.m
b08210b
@MostafaGomaa93
Add files via upload
64c39cd
@MostafaGomaa93
Update calculateBoundaryConditions.m
f869707
@MostafaGomaa93
Add files via upload
bd9fc01
@MostafaGomaa93
Update calculateBoundaryConditions.m
8f15322
@MostafaGomaa93
Update readModflowConfigs.m
8f1c9f6
@MostafaGomaa93
Update readModflowConfigs.m
83b98ab
@MostafaGomaa93
Update setBoundaryCondition.m
e7c8977
@MostafaGomaa93
Add files via upload
2bfdca5
@MostafaGomaa93
Update STEMMUS_SCOPE.m
203a81f
@MostafaGomaa93
Update setBoundaryCondition.m
d65dc5f
@MostafaGomaa93
Add files via upload
324fa31
@MostafaGomaa93
Update readGroundwaterSettings.m
0ff826e
@MostafaGomaa93
Delete src/+io/readModflowConfigs.m
7303bb4
@MostafaGomaa93
Update calculateBoundaryConditions.m
c90c1d9
@MostafaGomaa93
Update readGroundwaterSettings.m
4f1cb95
@MostafaGomaa93
Update solveSoilMoistureBalance.m
9e4e2b9
@MostafaGomaa93
Update STEMMUS_SCOPE_exe.m
897aaeb
@MostafaGomaa93
Update STEMMUS_SCOPE_exe.m
17647a7
@MostafaGomaa93
Update readGroundwaterSettings.m
a915cec
@MostafaGomaa93
Update STEMMUS_SCOPE.m
10ff3ac
@MostafaGomaa93
Update STEMMUS_SCOPE.m
e42b5e4
@MostafaGomaa93
Update setBoundaryCondition.m
106ff7d
@MostafaGomaa93
Update solveSoilMoistureBalance.m
9c22a3c
@MostafaGomaa93
Update solveSoilMoistureBalance.m
1ee87b6
@MostafaGomaa93
Update calculateBoundaryConditions.m
48e3e9a
@MostafaGomaa93
Update readGroundwaterSettings.m
2571730
@MostafaGomaa93
Update readGroundwaterSettings.m
dd51171
@MostafaGomaa93
Update readGroundwaterSettings.m
a3a7e47
SarahAlidoost
SarahAlidoost reviewed Feb 26, 2024
View reviewed changes
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
SarahAlidoost
SarahAlidoost reviewed Feb 26, 2024
View reviewed changes
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
SarahAlidoost
SarahAlidoost requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@SarahAlidoost SarahAlidoost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostafaGomaa93 Thank you for the implementations 👍 Good job on on choosing the variable names, very clear and meaningful. Please see my comments, if something is not clear, let us know. We can also discuss the changes in our meeting this week.

MostafaGomaa93 and others added 20 commits February 28, 2024 10:18
@MostafaGomaa93 @SarahAlidoost
Update src/+init/setBoundaryCondition.m
5815374 
Co-authored-by: SarahAlidoost <[email protected]>
@MostafaGomaa93 @SarahAlidoost
Update src/+soilmoisture/calculateBoundaryConditions.m
432d939 
Co-authored-by: SarahAlidoost <[email protected]>
@MostafaGomaa93
Update calculateBoundaryConditions.m
c8fd840
@MostafaGomaa93
Update calculateBoundaryConditions.m
d023b3c
@MostafaGomaa93
Update calculateBoundaryConditions.m
9812e7c
@MostafaGomaa93 @SarahAlidoost
Update src/+soilmoisture/solveSoilMoistureBalance.m
6158748 
Co-authored-by: SarahAlidoost <[email protected]>
@MostafaGomaa93 @SarahAlidoost
Update src/+soilmoisture/solveSoilMoistureBalance.m
f86ca9b 
Co-authored-by: SarahAlidoost <[email protected]>
@MostafaGomaa93
Update solveSoilMoistureBalance.m
eae4997
@MostafaGomaa93 @SarahAlidoost
Update src/+init/setBoundaryCondition.m
4890924 
Co-authored-by: SarahAlidoost <[email protected]>
@MostafaGomaa93 @SarahAlidoost
Update src/STEMMUS_SCOPE.m
e6f068c 
Co-authored-by: SarahAlidoost <[email protected]>
@MostafaGomaa93 @SarahAlidoost
Update src/STEMMUS_SCOPE.m
6d44cd0 
Co-authored-by: SarahAlidoost <[email protected]>
@MostafaGomaa93
Update STEMMUS_SCOPE.m
d4b2fa6
@MostafaGomaa93
Update STEMMUS_SCOPE_exe.m
3402f3b
@MostafaGomaa93
Update readGroundwaterSettings.m
b321222
@MostafaGomaa93
Update STEMMUS_SCOPE.m
aa33e03
@MostafaGomaa93
Update STEMMUS_SCOPE.m
4a34628
@SarahAlidoost
move the if stetment outside update
5310904
@SarahAlidoost
fix linter errors
f7372a3
@SarahAlidoost
re generate exe file
6a711f0
@SarahAlidoost
add changes to changelog
a154ba8
SarahAlidoost
SarahAlidoost approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostafaGomaa93 very nice additions to the code. Thank you. After merging this pull request, the branch SSM_v.0.0.2 will be deleted.

@SarahAlidoost SarahAlidoost merged commit 102654c into main Mar 1, 2024
1 check passed
@SarahAlidoost SarahAlidoost deleted the SSM_v.0.2 branch March 1, 2024 13:37
@MostafaGomaa93
Copy link
Contributor Author

@MostafaGomaa93 very nice additions to the code. Thank you. After merging this pull request, the branch SSM_v.0.0.2 will be deleted.

Thanks so much @SarahAlidoost for your guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahAlidoost SarahAlidoost SarahAlidoost approved these changes

@BSchilperoort BSchilperoort BSchilperoort left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MostafaGomaa93 @BSchilperoort @SarahAlidoost