Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip, popover): honor prevented events #11278

Merged
merged 5 commits into from
Jan 15, 2025
Merged

fix(tooltip, popover): honor prevented events #11278

merged 5 commits into from
Jan 15, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Jan 13, 2025 •
edited
Loading

Related Issue: #11244

Summary

  • updates tooltip and popover to take no action on prevented events
  • adds tests
  • This allows users to prevent an event instead of stopping propagation on it.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 13, 2025
@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 14, 2025
@driskull driskull marked this pull request as ready for review January 14, 2025 22:55
@driskull driskull changed the title fix(tooltip, popover): ignore prevented events fix(tooltip, popover): honor prevented events Jan 14, 2025
@driskull driskull requested a review from jcfranco January 14, 2025 22:55
benelan
benelan approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull merged commit 68f0723 into dev Jan 15, 2025
16 checks passed
@driskull driskull deleted the dris0000/popover-tooltip-prevented-events branch January 15, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @benelan