fix: fix open/close event emitting of initially open components #11306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use Web Animations API for better transition/animation handling
github-actions
bot
added
the
bug
jcfranco
added
the
skip visual snapshots
jcfranco
changed the title
driskull
approved these changes
Jan 15, 2025
jcfranco
deleted the
jcfranco/10703-fix-initially-open-close-event-emitting
branch
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10703
Summary
Fixes an issue where initially open components relied on fallback logic due to the starting animation/transition event having already fired before
onToggleOpenCloseComponentwas invoked.Notes
onToggleOpenCloseComponentonly when the transition-triggering prop is updatedpromisesspec test helper