feat(split-button, dropdown-item, button): update component tokens #9456
Conversation
alisonailea
requested review from
jcfranco,
eriklharper,
macandcheese,
Elijbet and
anveshmekala
| @@ -6,6 +6,10 @@ | |||
| * @prop --calcite-button-background-color: defines the component's background color. | |||
| * @prop --calcite-button-border-color: defines the component's border color. | |||
| * @prop --calcite-button-corner-radius: defines the component's corner radius. | |||
| * @prop --calcite-button-corner-radius-start-start: defines the component's start-start corner radius. Will fallback to --calcite-button-corner-radius if defined. | |||
There was a problem hiding this comment.
Should this, and similar lines, say if not defined vs if defined?
There was a problem hiding this comment.
I was thinking about this. I'm not sure what makes more sense. It will only fallback to the more general -corner-radius var if that var is defined. Which is why I used if defined but maybe that's implied?
There was a problem hiding this comment.
Are these just so Split Button can pass some through? Should these be made internal if so?
There was a problem hiding this comment.
Are these just so Split Button can pass some through? Should these be made internal if so?
I thought about that. My reasoning for making them public was that customers may be using calcite-buttons to create their own components with similar edge case requirements so providing the option to set the corners separately would be beneficial
| & calcite-icon { | ||
| color: theme("backgroundColor.brand"); | ||
| color: var(--calcite-dropdown-item-icon-color, theme("backgroundColor.brand")); |
There was a problem hiding this comment.
Should this be setting --calcite-icon-color?
| @@ -14,28 +172,134 @@ | |||
| @apply w-full; | |||
| } | |||
|
|
|||
| //--calcite-internal-split-button-loader-color: var(--calcite-color-inverse); | |||
There was a problem hiding this comment.
Commented out line should be removed. Applies to other commented-out lines.
If any commented-out line is waiting on a decision or question, let's add context and keep the comment.
There was a problem hiding this comment.
thanks for the catch
Related Issue: #7180
Summary
Add theme e2e tests and update tokens
In order to get proper styling of split button this required some updates to dropdown-item and button