Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsible widgets #186

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Collapsible widgets #186

merged 3 commits into from
Jan 30, 2024

Conversation

tmichela
Copy link
Member

Some users asked to be able to hide the plotting options at the botton of the UI, as they never use it and it takes space from the table.

damnit-collapse

@tmichela
collapsible widgets
fb7ccb5 
Make bellow widget collapsible for maximal table real estate

refactor
@tmichela
fixup remaining call to icon_path
333ee37
@tmichela tmichela requested a review from JamesWrigley January 30, 2024 09:22
JamesWrigley
JamesWrigley requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why exactly, but everything looks horizontally and vertically squished in the collapsible layout:
image

Compared to the default:
image

Not a big deal, but it would be nice if there was more padding.

damnit/gui/utils.py Outdated Show resolved Hide resolved
damnit/gui/widgets.py Outdated Show resolved Hide resolved
@tmichela
Copy link
Member Author

Fixed the layout (I was too agressive in removing margin 😁

Screenshot 2024-01-30 at 12 52 37

JamesWrigley
JamesWrigley approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmichela tmichela merged commit 2304460 into master Jan 30, 2024
3 checks passed
@tmichela tmichela deleted the collapsiblePanel branch January 30, 2024 13:11
@tmichela
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWrigley JamesWrigley JamesWrigley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmichela @JamesWrigley