-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gui reprocessing: take 2 #321
base: master
Are you sure you want to change the base?
Conversation
reload file for reprocess load variables from file check vars in file do not execute the context file on opening the reprocesing dialog, parse the ast instead save context information
I feel like I'm missing something, don't we already do this with the |
the |
But that's good enough I think, we can still distinguish context file variables and user-editable variables by checking their |
It's not just about user editable variables. |
Mmm ok, but those variables will still show up in the table and column settings dialog. I think the proper fix would be to prompt the user to clean up non-existent variables? It's already possible to delete variables from the database and HDF5 files, maybe we could have a |
I've also been wondering about automatically deleting variables which were previously in the context file but have no data (e.g. you renamed a function without it ever running successfully). |
An alternative to #307
Here we save the context information in the database when we either save it from the GUI or detect it has changed upon processing or context file checking.
Would that be a preferred approache? @JamesWrigley @takluyver
It's still fast to load if the context is saved from the editor, but will execute the context file if it has changed from an other source.
side effect: poor-man's version control for the context file.