[$250] LHN - RBR is missing from the report when it fails to export to QBO

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5324684&group_by=cases:section_id&group_id=309135&group_order=asc
Issue reported by: Applause Internal Team

Action Performed:

1. https://staging.new.expensify.com/
2. Log in with a new Gmail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to QBO
7. Wait for the sync to finish (refresh the browser if it's stuck at importing data)
8. Navigate to the workspace chat
9. Submit a manual expense with any amount, merchant, and category
10. Pay the expense "elsewhere"
11. Open the expense
12. Click on "Export to QuickBooks Online"
13. Wait a minute and refresh the browser

Expected Result:

RBR should be visible.

Actual Result:

RBR is missing from the report when it fails to export to QBO.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6690691_1733905188166.bandicam_2024-12-11_09-04-56-770.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866980041596226997
• Upwork Job ID: 1866980041596226997
• Last Price Increase: 2025-01-01
• Automatic offers:
• DylanDylann | Reviewer | 105609003

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Reproduced

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866980041596226997

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[joekaufmanexpensify]

cc @arosiclair as I see you originally implemented this

[arosiclair]

I'll manage this. I might take it internal if I get the cycles.

[joekaufmanexpensify]

TY!

[melvin-bot]

@arosiclair, @joekaufmanexpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[truph01]

I cannot trigger the error "failed to export the report to QuickBooks Online. @joekaufmanexpensify Could you give me a trick to reproduce it, please? Thanks

[joekaufmanexpensify]

@truph01 did you follow the steps in OP of the issue? I had no issue reproducing it with those steps.

[melvin-bot]

@arosiclair, @joekaufmanexpensify, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

[truph01]

@joekaufmanexpensify Yes, I followed the steps and got stuck on the screen below, where the message remains as "started exporting this report to QuickBooks Online..." instead of updating to "failed to export this report..." as mentioned by the OP:

[joekaufmanexpensify]

Interesting. Even after refreshing the browser?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[truph01]

Interesting. Even after refreshing the browser?

Yes

[melvin-bot]

@arosiclair, @joekaufmanexpensify, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[joekaufmanexpensify]

Got it. I'll try reproducing again to make sure I still can.

[joekaufmanexpensify]

I just tried again and could still reproduce it. @truph01 after exporting, try syncing the QBO connection to see if that triggers the error on the report.

[joekaufmanexpensify]

Moving this to weekly for now as I am OOO after today through EOY. If this needs any BZ urgently before then, please ask in Slack. Otherwise, I will continue to assist when I return.

[arosiclair]

Ah okay I just looked at the frontend and there are some changes that I think probably broke this. We changed logic for showing the RBR here. When the export fails, we set report.errorFields.export but it doesn't look like the new shouldShowRedBrickRoad function checks report.errorFields at all. If true, that's the root of the problem. That was changed in this PR cc @pac-guerreiro @DylanDylann @puneetlath

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[joekaufmanexpensify]

@arosiclair Thanks for investigating! Would this be a frontend fix?

[arosiclair]

@arosiclair Thanks for investigating! Would this be a frontend fix?

Yup that's correct

[joekaufmanexpensify]

Sounds good! I'll move this back to daily so we can look for proposals (unless you have interest in fixing it).

[joekaufmanexpensify]

cc @pac-guerreiro @DylanDylann in case you guys are interested too as it sounds like you worked on the PR that introduced this.

[DylanDylann]

@arosiclair Nice catch!

In this PR, we updated to use getAllReportActionsErrorsAndReportActionThatRequiresAttention instead of getAllReportErrors in shouldShowRedBrickRoad function

@pac-guerreiro It maybe our mistake while implementing and reviewing

[DylanDylann]

In this issue, I can't reproduce it but if When the export fails, we set report.errorFields.export I think the fix for the above problem will solve this bug

[DylanDylann]

@pac-guerreiro If you agree with above point, please raise a PR to address it

[melvin-bot]

@arosiclair @joekaufmanexpensify @thesahindia this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[pac-guerreiro]

@DylanDylann @arosiclair sorry for the bug! What you mentioned seems to make sense, so I'll try to apply your suggestions and check if it works 😄

[joekaufmanexpensify]

Reassigning this to @DylanDylann and @pac-guerreiro since they have context for this issue.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[pac-guerreiro]

@DylanDylann @arosiclair @IuliiaHerets @joekaufmanexpensify

I just opened a PR with the fix for this issue 😄

[pac-guerreiro]

Today I dedicated my time to write unit tests for this PR but I haven't finished them yet.

[pac-guerreiro]

PR was merged! 🚀

Thanks @DylanDylann and @arosiclair 😄

[joekaufmanexpensify]

Wooo, TY!