-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LHN - RBR is missing from the report when it fails to export to QBO #54981
base: main
Are you sure you want to change the base?
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@pac-guerreiro Could you solve the lint errors? I think it is minor change 😄 |
@DylanDylann ESLint check is failing because of default ID rules, which will be ignored once this PR is merged in a day or two 😄 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, however can we start adding unit tests for this? Let's add at least one that verifies shouldShowRedBrickRoad
returns true
when report.errorFields.export
is set. I tried to test this locally, but I'm having issues setting up a QBO connection in my environment atm, so unit tests are the way to go.
@arosiclair I agree with you! Today I dedicated my time to write unit tests for this PR but I haven't finished them yet. |
…the-report-when-it-fails-to-export-to-qbo
…the-report-when-it-fails-to-export-to-qbo
@arosiclair Sorry for the delay here, I just pushed a commit with a test suite for SidebarUtils 😄 |
Explanation of Change
Fixed Issues
$#53924
PROPOSAL: #53924 (comment)
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop