Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade moment from 2.29.4 to 2.30.1 #216

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

MelvinBot
Copy link

snyk-top-banner

Snyk has created this PR to upgrade moment from 2.29.4 to 2.30.1.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 2 versions ahead of your current version.

  • The recommended version was released on a year ago.

Release notes
Package name: moment from moment GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade moment from 2.29.4 to 2.30.1.

See this package in npm:
moment

See this project in Snyk:
https://app.snyk.io/org/expensify/project/35c87b83-0578-438a-9ce5-96d21d712614?utm_source=github&utm_medium=referral&page=upgrade-pr
@pecanoro pecanoro requested a review from a team January 6, 2025 17:10
@melvin-bot melvin-bot bot requested review from dangrous and removed request for a team January 6, 2025 17:10
@dangrous
Copy link
Contributor

dangrous commented Jan 6, 2025

Release notes don't seem to have any breaking changes, will play around a bit with dates and see if anything weird happens.

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine!

@dangrous
Copy link
Contributor

dangrous commented Jan 6, 2025

@pecanoro since you were on this - two questions:

  • Do you think it's fine to merge with that failing check? It's just for assigning a reviewer, right?
  • Should we update the version number of K2 for this? I'm not entirely sure if we need to or just grab it next time. It doesn't appear that there's actually any security issue here, it's just that it's been a year since the version was released.

@pecanoro
Copy link
Contributor

pecanoro commented Jan 6, 2025

Ah sorry, I forgot to leave a comment! We were trying to fix the auto-assigner here. You can merge with that check failing since it was the auto-assigner.

Since there are a couple more of PR from Snyk that need to be merged with fixes, I think you can skip bumping the version and we can do it when the rest of them get merged.

@dangrous
Copy link
Contributor

dangrous commented Jan 6, 2025

Okay cool! will merge.

@dangrous dangrous merged commit 06a5f59 into main Jan 6, 2025
3 of 4 checks passed
@dangrous dangrous deleted the snyk-upgrade-743f096a1d2c8566b18ed3c8f71fe753 branch January 6, 2025 20:56
@melvin-bot melvin-bot bot added the Emergency label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

@dangrous looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@dangrous dangrous removed the Emergency label Jan 6, 2025
@dangrous
Copy link
Contributor

dangrous commented Jan 6, 2025

Not emergency, auto assigner was the check that failed and it's just broken. Unrelated to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants