-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade moment from 2.29.4 to 2.30.1 #216
Conversation
Snyk has created this PR to upgrade moment from 2.29.4 to 2.30.1. See this package in npm: moment See this project in Snyk: https://app.snyk.io/org/expensify/project/35c87b83-0578-438a-9ce5-96d21d712614?utm_source=github&utm_medium=referral&page=upgrade-pr
Release notes don't seem to have any breaking changes, will play around a bit with dates and see if anything weird happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine!
@pecanoro since you were on this - two questions:
|
Ah sorry, I forgot to leave a comment! We were trying to fix the auto-assigner here. You can merge with that check failing since it was the auto-assigner. Since there are a couple more of PR from Snyk that need to be merged with fixes, I think you can skip bumping the version and we can do it when the rest of them get merged. |
Okay cool! will merge. |
@dangrous looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Not emergency, auto assigner was the check that failed and it's just broken. Unrelated to the code. |
Snyk has created this PR to upgrade moment from 2.29.4 to 2.30.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 2 versions ahead of your current version.
The recommended version was released on a year ago.
Release notes
Package name: moment
2.30.1
2.30.0
2.29.4
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: