Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent italic or strikethrough emojis on Android #591

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

Skalakid
Copy link
Collaborator

Details

This PR fixes adding italics and strikethrough style to the emojis on Android and web platforms. It adds range splitting algorithm in TypeScript to parseExpensiMark function so we won't interfere with the results of the custom parsers. This solution replaces #534 PR, as discussed internally cc @tomekzaw

Related Issues

Expensify/App#14676

Manual Tests

  1. To the text that contains emojis, add italics styling, e.g. _🥰 test 😇 test 🥹_
  2. Verify if the text has italics style and emojis don't
  3. Verify if it still works when adding other styles around it, e.g. # *~_🥰 test 😇 test 🥹_~*
  4. Verify if emojis aren't strikethrough
  5. Test it with different style combinations

Linked PRs

tomekzaw
tomekzaw previously approved these changes Jan 7, 2025
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I know it's been a long journey but the final effect is definitely worth it.

@Skalakid Skalakid merged commit 906f767 into main Jan 7, 2025
5 checks passed
@Skalakid Skalakid deleted the @Skalakid/fix-emoji-formatting-v2 branch January 7, 2025 11:49
@os-botify
Copy link
Contributor

os-botify bot commented Jan 7, 2025

🚀 Published to npm in 0.1.214 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants