Fix regression in Map deserialization in Scala 2.13 when default typing is enabled #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
changed the title
retronym
force-pushed
the
bug/643
branch
2 times, most recently
from
d6be7f0 to
87de69c
Compare
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in FasterXML#643 / FasterXML#470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes FasterXML#643
pjfanning
pushed a commit
that referenced
this pull request
Dec 4, 2023
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in #643 / #470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes #643
|
Thanks @retronym - I think this is safe to include in the 2.16.1 release, so I've backported it back to the 2.16 branch. I'm surprised that the core jackson-databind writes the pre-conversion class name with this change but it obviously works based on your test case. The test case should help us spot if the core jackson-databind library modifies this behaviour. |
pjfanning
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in #643 / #470.
This commit ensures that the wrapper class is a member class in both Scala and Java.
That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation.
Fixes #643