Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new models from Ignition Fuel #205

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Feb 17, 2022

Builds on top of #194
Demonstrates an example for #191

Adds new models (Lionfish, Niskin, Sunken Vase, Sunken Ship) Cole uploaded to the DAVE collection on Ignition Fuel.

They took a few iterations of troubleshooting. Sunken Vase 02 is commented out for now because it throws an OGRE error, and we're not sure why.

Inertial values are from MeshLab. I'm not planning to add inertia for the ship and the fish, since they're mostly for decoration and maybe for sensor scanning, not any kind of physical interaction. (At least... I wasn't told we were planning to do any deep sea fishing.)

To test:

roslaunch dave_demo_launch dave_models.launch

You should see messages printed about downloading the models from Ignition Fuel:

[Msg] Downloaded model URL: 
          https://fuel.ignitionrobotics.org/1.0/Cole/models/Sunken Vase
      to: 
...

They should show up like this (3 objects on the far right and the big ship):
Here I started Gazebo paused to show their initial poses. When unpaused, they fall to the ground and won't look upright.
2022-02-19-022811_1955x1183_scrot_SunkenShip
2022-02-19-022819_1955x1183_scrot

Inertia for Sunken Vase and Niskin:
2022-02-19-053157_3706x2049_scrot

@mabelzhang mabelzhang marked this pull request as ready for review February 19, 2022 07:36
Base automatically changed from feature/bsb/newmodels to master February 19, 2022 21:52
@woensug-choi
Copy link
Collaborator

woensug-choi commented Feb 22, 2022

  • Visual

image

  • Collision

image

Called in just fine 👍

Copy link
Collaborator

@woensug-choi woensug-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine-tuned collision model!

@mabelzhang
Copy link
Contributor Author

The collision models are currently just the mesh itself. We could make them into boxes later if that turns out to affect manipulation performance!

@mabelzhang mabelzhang merged commit 0b6cf7d into master Feb 22, 2022
@mabelzhang mabelzhang deleted the mabelzhang/fuel_models branch February 22, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants