Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
api
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8713 +/- ##
==========================================
- Coverage 98.86% 98.85% -0.01%
==========================================
Files 1674 1677 +3
Lines 69337 69148 -189
==========================================
- Hits 68548 68357 -191
- Misses 789 791 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
docs
khvn26
force-pushed
the
fix/refuse-system-segment-changes
branch
from
October 9, 2026 16:52
1e18a46 to
3cfd3ee
Compare
github-actions
Bot
added
fix
docs
SegmentSerializer refuses drafting versions of system segments, which also covers the change request serializers extending it, rather than waiting for their commit.
POST feature-segments/ in v2 environments drafts feature segments for the feature states of new versions, e.g. ones going through change requests, rather than overriding the live flag.
- Type the legacy feature state data validated by the legacy APIs. - Move the legacy override writes, and code reference notifications, to features/services.py. - Render APIErrorDetail bodies from a common APIError base class. - Mark legacy viewsets for removal as a whole.
- Keep the flag API's request schema refusing null values, and the versions request schema as it was, without TODOs. - Reword comments and docstrings.
- Run the lifecycle hooks of deleted feature segments, rather than replicating them. - Mark the services only legacy APIs use for removal.
… flag API Replacing a flag's overrides leaves its system segment overrides as they are, and PATCH updates flags partially, so the flag API no longer accepts system segment overrides written as they are. The legacy feature state API still does, as the dashboard writes every override of flags it saves.
The legacy APIs clear values themselves, without v2 feature versioning, so the flag API keeps its request types. Legacy segment override helpers move to features/feature_segments.
Creating overrides enabled or not already keeps their audit log to one entry, without comparing their values.
…vice Variants not written keep their weights, so writing some of them through the service, as the legacy feature state API does, could exceed 100%.
Also keeps get_next_segment_override_priority beyond the legacy APIs.
Experiments write their rollout overrides, and the default allocations, through features.future.services as owners of their rollout segments. This removes versioning_service.update_flag, update_multivariate_values and FlagChangeSet, their last consumer gone. MultivariateValueChangeSet moves to experimentation, its only user.
… them RolloutSpec carries the flag API's variants, which removes MultivariateValueChangeSet.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
WIP
Contributes to #8608
How did you test this code?
Please describe.