Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test cases of activation functions #162

Merged
merged 4 commits into from
Feb 8, 2020
Merged

Update test cases of activation functions #162

merged 4 commits into from
Feb 8, 2020

Conversation

matsueushi
Copy link
Contributor

@matsueushi matsueushi commented Jan 30, 2020

I slightly modified the definition of gelu because the previous definition didn't pass the gradient test in Julia 1.0 and 1.1. (https://travis-ci.org/matsueushi/NNlib.jl/builds/643663660?utm_medium=notification&utm_source=github_status)

It is related to pi and I found a similar issue. JuliaMath/Calculus.jl#144

@matsueushi matsueushi changed the title Update tests for activation functions Update test cases of activation functions Jan 30, 2020
@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #162 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage    70.7%   70.74%   +0.03%     
==========================================
  Files          24       24              
  Lines         874      875       +1     
==========================================
+ Hits          618      619       +1     
  Misses        256      256
Impacted Files Coverage Δ
src/activation.jl 95.45% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b896e33...e31ea20. Read the comment docs.

@matsueushi matsueushi mentioned this pull request Feb 5, 2020
Copy link
Contributor

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@staticfloat staticfloat closed this Feb 8, 2020
@staticfloat staticfloat reopened this Feb 8, 2020
@staticfloat
Copy link
Contributor

Let's see if CI is happier now that you've upgraded the deps.

@matsueushi
Copy link
Contributor Author

Thanks!

@staticfloat staticfloat merged commit 07852a8 into FluxML:master Feb 8, 2020
@matsueushi matsueushi deleted the test_activation branch February 8, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants