limit child allocation depth to MAX_TLV_STACK

FreeRADIUS · Oct 31, 2023 · 09ff0b4 · 09ff0b4
1 parent 1bca847
commit 09ff0b4
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/lib/util/dict_unknown.c b/src/lib/util/dict_unknown.c
@@ -324,6 +324,11 @@ fr_dict_attr_t *fr_dict_unknown_tlv_afrom_num(TALLOC_CTX *ctx, fr_dict_attr_t co
 		return NULL;
 	}
 
+	if (parent->depth >= FR_DICT_MAX_TLV_STACK) {
+		fr_strerror_const("Attribute depth is too large");
+		return NULL;
+	}
+
 	return dict_attr_alloc(ctx, parent, NULL, num, FR_TYPE_TLV,
 			       &(dict_attr_args_t){ .flags = &flags });
 }
@@ -353,6 +358,11 @@ fr_dict_attr_t	*fr_dict_unknown_attr_afrom_num(TALLOC_CTX *ctx, fr_dict_attr_t c
 		return NULL;
 	}
 
+	if (parent->depth >= FR_DICT_MAX_TLV_STACK) {
+		fr_strerror_const("Attribute depth is too large");
+		return NULL;
+	}
+
 	return dict_attr_alloc(ctx, parent, NULL, num, FR_TYPE_OCTETS,
 			       &(dict_attr_args_t){ .flags = &flags });
 }