Build packages for releases #2
Conversation
goreleaser.yml
Outdated
| - apk | ||
| - deb | ||
| - rpm | ||
| bindir: /usr/sbin |
There was a problem hiding this comment.
Why in sbin? I believe that is reserved for binaries that require root permissions, and hareply doesn't strictly require it (as long as the server port is >1024).
So I would make this /usr/bin instead.
assets/packages/hareply.service
Outdated
| Environment="PIDFILE=/run/hareply.pid" | ||
| EnvironmentFile=/etc/default/hareply | ||
| ExecStart=/usr/sbin/hareply | ||
| ExecReload=/bin/kill -s SIGUSR1 $MAINPID |
There was a problem hiding this comment.
hareply doesn't currently listen to this signal, no?
There was a problem hiding this comment.
You're right. This comes from the copy paste from how dataplaneapi does things for their systemd service: but we indeed do not need this or use it currently.
I'll remove this command entirely, as well as the PIDFILE options below
assets/packages/hareply.service
Outdated
| PIDFile= | ||
| GuessMainPID=1 |
There was a problem hiding this comment.
I'm not well versed in systemd unit files, but I'm curious: why set PIDFILE in the environment, but then make PIDFile blank and use GuessMainPID? I could look it up as well, but if you explain it then it saves me from reading systemd documentation 😅
There was a problem hiding this comment.
I looked into it in more detail, my conclusion in the end is that PID files should no longer be required for most services, and rather Type=simple should be sufficient [source]
Builds
deb,rpm,apkpackages.Based on haproxytech/dataplaneapi@0264138