chore!: Move get_asset_outputs_for_amount, `get_asset_inputs_for_am…
#1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` (#1498) # Release notes In this release, we: - Move `get_asset_outputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` # Summary This PR moves `get_asset_outputs_for_amount`, `get_asset_inputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` trait. It seem that these two methods doesn't require a full `Account` and so it give more flexibility in order to implement them in other structures such as `Wallet`. Now `Wallet` also implement these two methods. Before you were forced to build a `WalletUnlocked` even if you don't use the `secret_key`. # Breaking changes This contains an API breaking change as some public trait as been edited: # Breaking Changes The provider option flag `cacheUtxo` was renamed to `resourceCacheTTL` ```rust // before use fuels::acounts::Account; wallet.get_asset_outputs_for_amount(...); ``` ```rust // after use fuels::acounts::ViewOnlyAccount; wallet.get_asset_outputs_for_amount(...); ``` # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none) --------- Co-authored-by: hal3e <[email protected]> Co-authored-by: Rodrigo Araújo <[email protected]> Co-authored-by: MujkicA <[email protected]>
hal3e
requested review from
digorithm,
MujkicA,
segfault-magnet and
Salka1988
as code owners
segfault-magnet
approved these changes
Jan 7, 2025
Salka1988
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this release, we:
get_asset_outputs_for_amountandadjust_for_feefromAccounttoViewOnlyAccountSummary
This PR moves
get_asset_outputs_for_amount,get_asset_inputs_for_amountandadjust_for_feefromAccounttoViewOnlyAccounttrait. It seem that these two methods doesn't requirea full
Accountand so it give more flexibility in order to implementthem in other structures such as
Wallet.Now
Walletalso implement these two methods. Before you were forced tobuild a
WalletUnlockedeven if you don't use thesecret_key.Breaking changes
This contains an API breaking change as some public trait as been
edited:
Breaking Changes
The provider option flag
cacheUtxowas renamed toresourceCacheTTLChecklist
Co-authored-by: hal3e [email protected]
Co-authored-by: Rodrigo Araújo [email protected]
Co-authored-by: MujkicA [email protected]