-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug!: updating consensus parameters #1569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault-magnet
added
bug
Something isn't working
enhancement
New feature or request
labels
Jan 9, 2025
segfault-magnet
requested review from
digorithm,
hal3e,
MujkicA and
Salka1988
as code owners
January 9, 2025 14:41
segfault-magnet
added
bug
Something isn't working
and removed
bug
Something isn't working
enhancement
New feature or request
labels
Jan 9, 2025
segfault-magnet
changed the title
feat!: updating consensus parameters
bug!: updating consensus parameters
Jan 9, 2025
hal3e
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Salka1988
approved these changes
Jan 9, 2025
MujkicA
approved these changes
Jan 9, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
ConsensusParameters
cache expire-able inProvider
Summary
The
Provider
now evicts the cachedConsensusParameters
after the preconfigured TTL (defaulted to 60s).You can change the TTL by doing:
If you want to clear the cache immediately you can do so by:
Breaking Changes
The
consensus_parameters
method inProvider
is nowasync
and fallable:The following methods have been removed:
base_asset_id
-- now acquired byprovider.consensus_parameters().await?.base_asset_id()
chain_id
-- now acquired byprovider.consensus_parameters().await?.chain_id()
Checklist