Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animtion card on idex page and and sparde borderand transition o… #827

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+296 −303
Open

Add animtion card on idex page and and sparde borderand transition o… #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
373dd60
Add animtion card on idex page and and sparde borderand transition o…
Mahendraish Oct 22, 2024
c0ddf33
Styling sing up page and enhancing... Footer
Mahendraish Oct 31, 2024
42bd830
Update signup.html
Mahendraish Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,14 @@
padding-bottom: 5rem;
}
.about h1{
font-size: 4rem;
font-size: 5rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Add media queries for .about h1 to ensure responsiveness.

Currently, there are no media queries adjusting the font size of .about h1, which may cause layout issues on smaller screens. Please consider adding responsive styles to modify the heading size for different screen widths.

🔗 Analysis chain

Verify responsiveness and readability of updated text styles.

The font size for .about h1 has been increased, and italic style has been added to .about p. While these changes may enhance visual appeal, please consider the following:

  1. Verify that the larger heading (5rem) doesn't cause layout issues on smaller screens.
  2. Assess the readability of the italic paragraph text, especially for longer content.

Consider adding media queries to adjust the heading size for smaller screens if necessary.

Also applies to: 347-347

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for existing media queries related to .about h1 font-size
rg -i "\.about\s*h1.*font-size" about.html

Length of output: 414

Script:

#!/bin/bash
# Search for media queries that adjust .about h1 font-size
rg -i '@media' about.html | rg -i '\.about\s*h1.*font-size'

Length of output: 59

Script:

#!/bin/bash
# Extract all media queries and search for any font-size adjustments within them
rg -i '@media' about.html -A 20 | rg -i 'font-size'

Length of output: 178

margin-bottom: 1rem;
font-weight: 600;
}
.about p{
width: 70%;
font-size: 1.8rem;
font-style: italic;
}
.cards{
width: 100%;
Expand All @@ -357,9 +358,16 @@
padding: 2rem;
border-radius: 2rem;
background-color: #f8f9fa;
transition: all;
transition-duration: 1s;
transition-delay: 0s;

}
.card:hover{
scale: 105%;
transform: scale(1.02);
box-shadow: 2px 3px 4px 4px rgb(51, 9, 88);

}
.card h2{
font-size: 2.8rem;
Expand Down Expand Up @@ -432,7 +440,7 @@ <h1>Resum Resume</h1>
</nav>
<div class="panel-1">
<div class="about">
<h1>About</h1>
<h1 style="color: #4c0359;">About</h1>
<p>LinkedIn Resume Builder simplifies your job search by converting your LinkedIn profile into a professional resume. In just a few clicks, you can generate a polished resume from your profile, saving time and effort. With accurate data and a selection of professional templates, it’s the easiest way to create a standout resume quickly and efficiently.</p>
</div>
<div class="cards">
Expand Down
82 changes: 80 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,52 @@
transition: transform 0.3s, box-shadow 0.3s, z-index 0.3s;
position: relative;
z-index: 1;

}


.features-card:hover {
transform: translateY(-10px) scale(1.1);
box-shadow: 0 4px 8px #0073b1;
z-index: 3;
animation-name: cardani;
animation-duration: 1s;
animation-delay: 0s;
animation-iteration-count: infinite;
border: 2px solid red;
}
Comment on lines +59 to +64
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Refine the border animation in .features-card:hover

The border: 2px solid red; in the :hover state sets a static red border, but the subsequent animation changes the border-color over time. This may cause a visual inconsistency at the start of the hover effect. Consider setting the initial border-color to match the starting color of the animation or remove the static border color to allow the animation to transition smoothly.

Apply this diff to adjust the border styling:

.features-card:hover {
  transform: translateY(-10px) scale(1.1);
  box-shadow: 0 4px 8px #0073b1;
  z-index: 3;
  animation-name: cardani;
  animation-duration: 1s;
  animation-delay: 0s;
  animation-iteration-count: infinite;
-  border: 2px solid red;
+  border: 2px solid #ff6f61; /* Match starting color of animation */
}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
animation-name: cardani;
animation-duration: 1s;
animation-delay: 0s;
animation-iteration-count: infinite;
border: 2px solid red;
}
animation-name: cardani;
animation-duration: 1s;
animation-delay: 0s;
animation-iteration-count: infinite;
border: 2px solid #ff6f61; /* Match starting color of animation */
}

@keyframes cardani {
10%{
border-color: #ff6f61;
}
20%{
border-color: #de8c3e;
}
30%{
border-color: brown;
}
40%{
border-color: aqua;
}

50%{
border-color: chartreuse;
}
60%{
border-color: burlywood;
}
70%{
border-color: red;
}

80%{
border-color: blue;
}

90%{
border-color: black;
}
Comment on lines +65 to +95
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Consolidate duplicate animations to avoid redundancy

The @keyframes cardani animation defined here appears to be duplicated later as @keyframes cardanii. This duplication can lead to increased file size and maintenance challenges. Consider consolidating these animations into a single definition if they are intended to perform the same effect.

}

.features-card img {
width: 60px;
height: 60px;
Expand Down Expand Up @@ -267,7 +305,44 @@
transform: translateY(-10px) scale(1.1);
box-shadow: 0 4px 8px #0073b1;
z-index: 3;
border: 2px solid grey;
animation-name: cardanii;
animation-duration: 2s;
animation-delay:0s;
animation-iteration-count: infinite;
}
@keyframes cardanii {
10%{
border-color: #ff6f61;
}
20%{
border-color: #de8c3e;
}
30%{
border-color: brown;
}
40%{
border-color: aqua;
}

50%{
border-color: chartreuse;
}
60%{
border-color: burlywood;
}
70%{
border-color: red;
}

80%{
border-color: blue;
}

90%{
border-color: black;
}
}
Comment on lines +308 to +345
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Remove redundant @keyframes cardanii animation

The @keyframes cardanii defined here duplicates the earlier @keyframes cardani. To adhere to the DRY (Don't Repeat Yourself) principle, remove the redundant animation or ensure that both animations are intentionally different.

Apply this diff to remove the redundant animation:

- @keyframes cardanii {
-   /* Duplicate animation steps */
- }

Committable suggestion was skipped due to low confidence.


/* < !-- Features Section --><style>.features {

Expand Down Expand Up @@ -852,6 +927,9 @@
height: 100%;
background-color: #3f10ea;
}
#resumec{
columns: rgb(20, 198, 8);
}
Comment on lines +930 to +932
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Correct the invalid CSS property in #resumec

The CSS property columns: rgb(20, 198, 8); is invalid, as columns is used for multi-column layouts, not for setting colors. If the intention is to change the text color, you should use the color property.

Apply this diff to fix the property:

#resumec {
-  columns: rgb(20, 198, 8);
+  color: rgb(20, 198, 8);
}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#resumec{
columns: rgb(20, 198, 8);
}
#resumec{
color: rgb(20, 198, 8);
}


</style>
</head>
Expand Down Expand Up @@ -884,7 +962,7 @@
<!-- home section starts -->
<section class="home" id="Home">
<div class="content">
<h3>Build Your Resume in Seconds from LinkedIn</h3>
<h3 id="resumec">Build Your Resume in Seconds from LinkedIn</h3>
<p>Easily generate a professional resume using your LinkedIn profile. Select a template, enter your LinkedIn URL,
and get a downloadable resume in a few clicks. Save time and create a resume that stands out.</p>
<a href="signup.html" class="btn">Get Started</a>
Expand Down
Loading