[retail] Fix error when changing guild bank permissions

Gethe · Feb 27, 2022 · 4f1de8c · 4f1de8c
1 parent baa7c70
commit 4f1de8c
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,14 +1,15 @@
 ## [9.1.5.1] ##
 ### Fixed ###
 
-  * [tbc] LFG skin was broken
-  * [classic] An extra texture was visible when at max level and not tracking any reputations
   * The "At War" check box in the reputations frame was out of place
   * The reputation detail frame had an out of place background
+  * [retail] Various fixes for 9.2.0
+  * [retail] Error when changing guild bank permissions
+  * [classic] An extra texture was visible when at max level and not tracking any reputations
   * [classic] Error when mousing over the skill detail status bar
   * [classic] Spellbook tabs would not react to mouse input
+  * [tbc] LFG skin was broken
   * [tbc] The character title dropdown had a misaligned backdrop
-  * [retail] Various fixes for 9.2.0
 
 
 ## [9.1.5.0] ##

diff --git a/Skin/Retail/Interface/AddOns/Blizzard_GuildControlUI.lua b/Skin/Retail/Interface/AddOns/Blizzard_GuildControlUI.lua
@@ -44,7 +44,6 @@ do --[[ AddOns\Blizzard_GuildControlUI.xml ]]
         Base.CropIcon(Frame.owned.tabIcon, Frame.owned)
         Skin.GuildPermissionCheckBoxTemplate(Frame.owned.viewCB)
         Skin.GuildPermissionCheckBoxTemplate(Frame.owned.depositCB)
-        Skin.GuildPermissionCheckBoxTemplate(Frame.owned.infoCB)
         Skin.InputBoxTemplate(Frame.owned.editBox)
 
         --Skin.SmallMoneyFrameTemplate(Frame.buy.money)
@@ -57,30 +56,36 @@ function private.AddOns.Blizzard_GuildControlUI()
     _G.hooksecurefunc("GuildControlUI_RankOrder_Update", Hook.GuildControlUI_RankOrder_Update)
     _G.hooksecurefunc("GuildControlUI_BankTabPermissions_Update", Hook.GuildControlUI_BankTabPermissions_Update)
 
-    Skin.TranslucentFrameTemplate(_G.GuildControlUI)
+    local GuildControlUI = _G.GuildControlUI
+    Skin.TranslucentFrameTemplate(GuildControlUI)
     _G.GuildControlUITopBg:Hide()
     Skin.HorizontalBarTemplate(_G.GuildControlUIHbar)
     Skin.UIPanelCloseButton(_G.GuildControlUICloseButton)
-    Skin.UIDropDownMenuTemplate(_G.GuildControlUI.dropdown)
+    Skin.UIDropDownMenuTemplate(GuildControlUI.dropdown)
+    GuildControlUI.dropdown.Button:SetWidth(24)
 
     Skin.RankChangeTemplate(_G.GuildControlUIRankOrderFrameRank1)
     Skin.UIPanelButtonTemplate(_G.GuildControlUIRankOrderFrame.newButton)
     Skin.UIPanelButtonTemplate(_G.GuildControlUIRankOrderFrame.dupButton)
 
-    Skin.UIDropDownMenuTemplate(_G.GuildControlUI.bankTabFrame.dropdown)
-    Skin.InsetFrameTemplate2(_G.GuildControlUI.bankTabFrame.inset)
-    Skin.UIPanelScrollFrameTemplate2(_G.GuildControlUI.bankTabFrame.inset.scrollFrame)
+    local bankTabFrame = GuildControlUI.bankTabFrame
+    Skin.UIDropDownMenuTemplate(bankTabFrame.dropdown)
+    bankTabFrame.dropdown.Button:SetWidth(24)
+    Skin.InsetFrameTemplate2(bankTabFrame.inset)
+    Skin.UIPanelScrollFrameTemplate2(bankTabFrame.inset.scrollFrame)
 
-    Skin.UIDropDownMenuTemplate(_G.GuildControlUI.rankPermFrame.dropdown)
-    Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUI.rankPermFrame.OfficerCheckbox)
-    Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUI.rankPermFrame.InviteCheckbox)
+    local rankPermFrame = GuildControlUI.rankPermFrame
+    Skin.UIDropDownMenuTemplate(rankPermFrame.dropdown)
+    rankPermFrame.dropdown.Button:SetWidth(24)
+    Skin.GuildPermissionCheckBoxTemplate(rankPermFrame.OfficerCheckbox)
+    Skin.GuildPermissionCheckBoxTemplate(rankPermFrame.InviteCheckbox)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox7)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox6)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox8)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox2)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox15)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox19)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox16)
-    Skin.InputBoxTemplate(_G.GuildControlUI.rankPermFrame.goldBox)
+    Skin.InputBoxTemplate(rankPermFrame.goldBox)
     Skin.GuildPermissionCheckBoxTemplate(_G.GuildControlUIRankSettingsFrameCheckbox18)
 end
diff --git a/Skin/Retail/Interface/SharedXML/SharedUIPanelTemplates.lua b/Skin/Retail/Interface/SharedXML/SharedUIPanelTemplates.lua
@@ -580,9 +580,9 @@ do --[[ SharedXML\SharedUIPanelTemplates.xml ]]
     function Skin.UIPanelScrollFrameTemplate2(Slider)
         Skin.UIPanelScrollFrameTemplate(Slider)
 
-        local name = Slider:GetName()
-        _G[name.."Top"]:SetAlpha(0)
-        _G[name.."Bottom"]:SetAlpha(0)
+        Slider.Top:SetAlpha(0)
+        Slider.Bottom:SetAlpha(0)
+        Slider.Middle:SetAlpha(0)
     end
     function Skin.MinimalScrollBarTemplate(Slider)
         Slider.trackBG:Hide()