Fix default attribute modifiers in item tooltip #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default item attribute modifiers in the tooltip to match Java behaviour.
Before:
After:
The PR also makes use of all translations for the equipment slot groups, shrinking big tooltips like these:
Down to these:
Lastly, this PR also fixes attribute modifiers for the
minecraft:knockback_resistanceattribute displaying wrongly (modifiers for these attribute show 10 times the value, which was implemented in Geyser, but wasn't properly updated whengeneric.knockback_resistancechanged intoknockback_resistance).