Skip to content

fix: update eslint rules from deprecated node/ to n/ prefix - #4493

Open
yuhuayang-google wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
yuhuayang-google:fix/eslintrc-rule-prefixes-4174
Open

yuhuayang-google wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
yuhuayang-google:fix/eslintrc-rule-prefixes-4174

Conversation

@yuhuayang-google

Copy link
Copy Markdown

Fixes #4174

Description

The repository uses gts (v5.3.0) and eslint-plugin-n, where Node-related rules are registered under the n/ namespace rather than the deprecated node/ namespace.

Updating the rule definitions in .eslintrc.json ensures the rules are recognized and applied properly rather than causing linter warnings or being ignored.

@yuhuayang-google
yuhuayang-google requested review from a team as code owners September 29, 2026 18:13
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Sep 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ESLint configuration in .eslintrc.json to replace the deprecated node/ rule prefix with the updated n/ prefix. I have no feedback to provide as there are no review comments.

@iennae iennae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eslintrc rules may be invalid

2 participants