Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gae): migrate region tags step 1 & 3 - mail/app.yaml #13045

Conversation

eapl-gemugami
Copy link
Contributor

@eapl-gemugami eapl-gemugami commented Jan 9, 2025

Description

Fixes Internal: b/388587061

Documentation won't be updated as it refers to frozen samples: https://cloud.google.com/appengine/docs/standard/services/mail/receiving-mail-with-mail-api

Checklist

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, chore(gae): migrate region tags step 1 - add new region tags to mail/app.yaml, aims to add new region tags to the app.yaml file within the appengine/standard/mail directory. This is part of a larger migration effort (tracked in b/388587061).

Specifically, the changes include:

  • Adding new region tags around existing comment blocks in appengine/standard/mail/app.yaml.
    • Lines 19-25 were modified to add # [START gae_mail_service_yaml_python] and # [END gae_mail_service_yaml_python].
    • Lines 34-40 were modified to add # [START gae_handle_incoming_email_yaml_python] and # [END gae_handle_incoming_email_yaml_python].
    • Lines 41-43 were modified to add # [START gae_handle_all_email_yaml_python] and # [END gae_handle_all_email_yaml_python].
    • Lines 54-60 were modified to add # [START gae_handle_bounced_email_yaml_python] and # [END gae_handle_bounced_email_yaml_python].

The author has indicated that all lint checks passed and followed the sample guidelines.

I'll provide a more detailed review soon.


A little poem for your coding pleasure:

Tags in YAML files,
Region markers, neatly placed,
Code now runs clear.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Jan 9, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds new region tags to the app.yaml file for the App Engine mail samples. The changes look good and follow the expected format for region tags. Since this is step 1 of a larger migration, it's understandable that this PR only focuses on adding the new tags.

It's good practice to break down large migrations into smaller, manageable steps like this.

@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 9, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 9, 2025
Copy link

snippet-bot bot commented Jan 9, 2025

Here is the summary of changes.

You are about to add 4 region tags.
You are about to delete 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@eapl-gemugami eapl-gemugami marked this pull request as ready for review January 9, 2025 19:19
@eapl-gemugami eapl-gemugami requested review from a team as code owners January 9, 2025 19:19
@eapl-gemugami eapl-gemugami changed the title chore(gae): migrate region tags step 1 - add new region tags to mail/app.yaml chore(gae): migrate region tags step 1 & 3 - mail/app.yaml Jan 9, 2025
@eapl-gemugami eapl-gemugami merged commit 742c4a8 into GoogleCloudPlatform:main Jan 10, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/gae/migrate-regions-step-1-in-mail-app-yaml branch January 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants