Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactorings #111

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Minor refactorings #111

merged 2 commits into from
Aug 23, 2024

Conversation

lauft
Copy link
Member

@lauft lauft commented Aug 23, 2024

Two minor refactorings were applied

  • the error message for the test of the holiday flags was enhanced to show the actual flags as well
  • The date functions for Ramazan Bayramı and Kurban Bayramı were fixed to return None if the dates are undefined instead of raising an exception

lauft added 2 commits August 20, 2024 23:21
@lauft
Stabilize 'ramazan_bayrami_day' and 'kurban_bayrami_day'
ace55a8 
Check whether reference lookup returned None before applying shift

Signed-off-by: Thomas Lauf <[email protected]>
@lauft
Enhance error message
12f345f 
Signed-off-by: Thomas Lauf <[email protected]>
@lauft lauft merged commit 5655aae into main Aug 23, 2024
13 checks passed
@lauft lauft deleted the feature/refactoring branch August 23, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lauft