-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Andalusia region (AN) holidays #56
The head ref may contain hidden characters: "Andaluc\u00EDa"
Conversation
Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
when Epifanía del Señor (01-06) is sunday Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
when Inmaculada Conceptción is on sunday Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
when national Fiesta del Trabajo (05-01) holiday is on Sunday Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
when national Navidad holiday is on Sunday Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
when Andalucia's day (02-28) is Sunday Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
Thanks for your contribution! 👍 |
I used those references For Andalusia Also checked https://www.calendarioslaborales.com/ they could be used to check holidays in other Spanish regions and locations but is not an official source and could contain errors. |
From the first reference (https://administracion.gob.es/pag_Home/atencionCiudadana/calendarios/laboral.html) you can find this legal document https://www.boe.es/diario_boe/txt.php?id=BOE-A-2019-14552 |
In Spain is very common to have Monday holidays when a fixed one is on Sunday but it is a regional decision. I added those that Andalusia region had done for many years (2006 - 2020) as far as I have researched. I think generally others regions could be included but they need to be checked one by one. Maybe is better to assume that the Sunday holiday produced a Monday holiday and make correction when we discover this is not true for any region. I am open to suggestions. |
I probably will do more addition and correction from official documents. Including for other regions besides Andalusia. I need to change branch name as my first intention was just to add regional holidays as in commit e8c69ce. |
Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
01-06 is know as 'Día de Reyes' but this is an informal name, officially the name is 'Epifanía del Señor' 11-01 'Día de Todos los Santos' or 'Festividad de Todos los Santos' both refer to 'Todos los Santos' day or holiday 12-06 'Día de la Constitución Española' the official name is explicit because in Spain we have regional constitutions also Reference: https://www.boe.es/boe/dias/2019/10/11/pdfs/BOE-A-2019-14552.pdf Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
I think I pushed a change in the middle of the checks. I will check logs later. I need to leave. |
It is customary to stop working early even at noon to let people have dinner with their families or friends But they are not official holidays Signed-off-by: Vicente Jimenez Aguilar <[email protected]>
I see, I need to check tests because I changed names and remove some days. I will do later. |
You most probably will need to update the snapshots by calling
|
Thanks for the tip. I'm going to close this pull request a prepare a new one updating code and tests snapshots. |
Some of these holidays could be celebrated in others regions of Spain. At least they are correct for Andalusia region (AN).