Add locale et-EE

[lauft]

This adds the locale et-EE (Estonia) according to the Public Holidays and Days of National Importance Act
(Pühade ja tähtpäevade seadus)

Before merging, the following has to be resolved:

• Have there been any changes to the listed holidays since 2011?
• Ülestõusmispühade 1. püha refers to Easter Sunday
• Nelipühade refers to Pentecost Sunday

[h0adp0re]

Before merging, the following has to be resolved:

*  Have there been any changes to the listed holidays since 2011?

*  Ülestõusmispühade 1. püha refers to Easter Sunday

*  Nelipühade refers to Pentecost Sunday

• The current state of the law can be seen if you press the "In force" button on the right hand side in the article header. I gave it a once-over and everything seems to be in order.
• Correct, Ülestõusmispühade 1. püha is Easter Sunday.
• Correct, Nelipühade 1. püha is Pentecost Sunday, a.k.a. Whit Sunday a.k.a. Whitsun. I've commented on the correct name separately in the diff.

Thanks for taking the time, I appreciate it!

[h0adp0re]

I looked at the German holidata file and realized you probably have some days which are legally designated half-workdays? Am I right? If so, can you please add such days here as well? I will provide data.

[lauft]

I looked at the German holidata file and realized you probably have some days which are legally designated half-workdays? Am I right? If so, can you please add such days here as well? I will provide data.

Can you tell me to which days you are referring to? Currently I am not aware that there are legally defined half-holidays in Germany. There are some days, where it is custom to stop work early in the afternoon/after lunch, but this is not legally binding and depends on your employer in my experience.

Holidata tries to focus on the "holidays defined by law" as the smallest common ground, therefore I would rather remove such holidays from the database... but this depends on the specific case.

[h0adp0re]

Can you tell me to which days you are referring to? Currently I am not aware that there are legally defined half-holidays in Germany. There are some days, where it is custom to stop work early in the afternoon/after lunch, but this is not legally binding and depends on your employer in my experience.

I'm sorry, it's possible I am mistaken, I merely skimmed the file. Maybe the act of skimming it reminded me that such things exist.

Holidata tries to focus on the "holidays defined by law" as the smallest common ground, therefore I would rather remove such holidays from the database... but this depends on the specific case.

That's understandable. There are 4 dates defined in our law that are to be 3 hours shorter workdays. This applies to all workers who work according to the standard business schedule, but not to workers who have a variable schedule as per their contract.

I refer you to § 53. of our Employment Contracts Act – Shortening of working time:

An employer shall shorten the working day preceding New Year’s Day, the anniversary of the Republic of Estonia, Victory Day and Christmas Eve by three hours.

[lauft]

I refer you to § 53. of our Employment Contracts Act – Shortening of working time

There is #36 which might be also applicable to this case, but here it seems that only the mandatory work hours on those days have to be reduced by 3 hours, right? So there are some employees who might start earlier than others?

Until #36 is resolved, I would leave those cases out...

[lauft]

The current state of the law can be seen if you press the "In force" button on the right hand side in the article header. I gave it a once-over and everything seems to be in order.

Holidata strives to deliver correct data from 2011 on (of course the main focus is on the current/coming year).

I tried to check the laws from previous years and did not spot any differences, but the process of selection of the different versions/years was not really clear to me and I hoped the original version would be a bit clearer.

[lauft]

I updated the PR according to your review comments. If there haven't been any changes to holidays since 2011, we are good to go. 🚀

[h0adp0re]

There is #36 which might be also applicable to this case, but here it seems that only the mandatory work hours on those days have to be reduced by 3 hours, right?

Yes, mandatory hours are reduced.

So there are some employees who might start earlier than others?

Yes, if your employment contract specifies non-standard working hours, the law might not apply to you, since those reduced hours are discounted from elsewhere. It is a bit confusing but that's non-standard for ya...

Otherwise no, I don't think anyone starts earlier just to still work 8 hours and get off work at the same time as their colleagues. If the law applies to you, your workday is shortened by 3 hours.

Until #36 is resolved, I would leave those cases out...

Yes, that is acceptable. It's a bit of an edge case anyway.

[h0adp0re]

I tried to check the laws from previous years and did not spot any differences, but the process of selection of the different versions/years was not really clear to me and I hoped the original version would be a bit clearer.

It can be a bit confusing, yes. I find it to be easiest with the "Compare wordings" button.

Between 2011 and now the public holidays haven't changed, so we're good there.

There have been a couple of changes in days of national importance but since those aren't needed in this project, we're good there as well.

I updated the PR according to your review comments. If there haven't been any changes to holidays since 2011, we are good to go. 🚀

Then we are good to go, looks good!

LGTM and thank you for your time!

[lauft]

LGTM and thank you for your time!

Thank you for your time as well. 👍🏻
Hope you keep can an eye on those laws and give a head up in case something changes. ❤️

[h0adp0re]

LGTM and thank you for your time!

Thank you for your time as well. 👍🏻 Hope you keep can an eye on those laws and give a head up in case something changes. ❤️

I will do my best!