-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale en-AU #84
Add locale en-AU #84
Conversation
Thanks for your contribution. I'll try to address your questions the next days. |
According to the wiki article, the AFL Grand Final is a gazetted holiday.
Half days are not fully supported (see #36), so they can either be implemented as fulll days but with a note "7pm to 12pm", or omitted.
As with partial holidays, one could either incorporate or omit them. One could decide based on whether they are of interest for the majority/a large part of the (regional) population.
The best solution IMHO is to provide such a holiday by a dedicated function. A new souvereign will get a new function providing the new holiday with adapted date and name.
OK.
Yes. Currently, Holidata is restricted to regions and sub-regions as defined by ISO. Also here one could either incorporate them for the respective region with a note, or omit them. |
Thanks for the feedback.
My hesitation here is that an educated guess requires correction if it's wrong, so the holiday data will require an active maintainer ~twice a year to update the fixed values. If we could approximate a rule that gets a majority of historical dates correct, hard-code fixes for the remaining, and attach "to be confirmed" to future dates (until they can be confirmed), is that acceptable?
I was leaning towards this, so thanks for confirming it.
Noted. I suspect this may also apply to some other Commonwealth nations, but I haven't checked.
My inclination is to not include them; the entire example order covers one or two hundred thousand people at most (of ~8 million), and other states would be similar. |
As the annual confirmation process will be to enter the dates for the respective year in an internal table/map/function, I would use the approximation only to provide future dates – thus hard-code all past dates.
Yes, and not only the Commonwealth: Japan, and the Netherlands, and most likely any other country with a monarch... 🙂 |
This adds the holidays for locale
en-AU
(addressing #69) according to relevant state and territory laws:Outstanding issues that require resolving before this can be merged:
Additional notes: