Fix gte errors #43
Merged
Fix gte errors #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evading
force-pushed
the
fix-gte-errors
branch
2 times, most recently
from
3b0e81e to
89e30fa
Compare
|
Looks good to me |
evading
force-pushed
the
fix-gte-errors
branch
from
89e30fa to
d87b467
Compare
This change fixes some issues where watermark sizes were interpreted the wrong way. Before this commit, watermarks for Rx FIFOs and Tx Event FIFO were clamped to the maximum permissible watermark. But the behavior according to the users manual is that watermark sizes over the maximum permissible will disable the corresponding interrupt. P.31 and p.34 of the M_CAN users manual v330 states that Rx FIFO Watermarks, FnWM, can take values 1-64 inclusive. Any value greater than 64 is interpreted as "Watermark interrupt disabled". P.44 of the M_CAN users manual v330 states that the Tx Event FIFO Watermark, EFWM, can take values 1-32 inclusive, Any value greater than 32 is interpreted as "Watermark interrupt disabled". This change makes the implementation consistent with the users manual on those specifics. A value greater than the maximum will be changed to zero for consistency. The bit ranges are 6 bits wide for the Tx Event and 7 bits wide for the Rx configs but the u8 datatype is used in the software interface. That u8 will be masked and shifted so that f.ex. writing 129 to either bit range will actually set the value to 1, not consistent with the user manual. Clamping to any value over the maximum seems arbitrary, and for that reason values larger than the maximum permissible are set to zero, which also disables the interrupt.
evading
force-pushed
the
fix-gte-errors
branch
from
d87b467 to
679d891
Compare
Ironedde
approved these changes
Oct 24, 2023
Ironedde
pushed a commit
to Ironedde/mcan-clone
that referenced
this pull request
Oct 24, 2023
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Merged
Ironedde
pushed a commit
to Ironedde/mcan-clone
that referenced
this pull request
Oct 24, 2023
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Ironedde
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some issues where watermark maximum sizes were interpreted the wrong way. Leading to watermarks clamping to the maximum value instead of disabling interrupts on overflow, as per the spec.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo +stable fmtwas run.cargo +stable clippyyields nowarnings.CHANGELOG.mdin the proper section.newly added features and code.