Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Path Prefix #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-centore
Copy link

Description

Adds the ability to customize the public path of AWS files using a custom prefix instead of pulling from the AWS library

Motivation and context

This makes it possible to use a CDN (like Cloudflare) in-between AWS (or compatible) and the user

How has this been tested?

  • Created Backblaze B2 bucket and configured to work with my Omeka S instance without using this new feature
  • Confirmed I can access file attachments and that the URLs are of the form https://bucketname.s3.region.backblazeb2.com/...
  • Followed instructions at https://www.backblaze.com/blog/free-image-hosting-with-cloudflare-transform-rules-and-backblaze-b2/ to configure to configure Backblaze+Cloudflare
  • Added a Public Path Prefix of the form https://cdn.mydomain.com/file/bucketname to the AnyCloud settings
  • Confirmed I can still access file attachments and that the URLs are of the form https://cdn.mydomain.com/file/bucketname/...

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@daniel-centore daniel-centore force-pushed the dfc/aws-public-path-prefix branch from d8f3349 to bdba8f2 Compare August 24, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant