Fixes inaccurate memberCount in Guilds and Parties - fixes #12286 #12885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/leaves The recomputation of memberCount in groups when a user joins/leaves it was currently only being done for Parties. I extended this functionality to Guilds as well, such that this recomputation now occurs for both Parties and Guilds.
paglias
suggested changes
Dec 15, 2020
| group.memberCount += 1; | ||
| } | ||
| // Set group's new memberCount | ||
| const currentMembers = await group.getMemberCount(); |
There was a problem hiding this comment.
Hi @lsophie , thanks for the PR. I'm a bit confused about the PR because group.getMemberCount() is not currently using transactions, it's manually counting documents from the database. The idea to fix this issue is to remove group.getMemberCount() and instead wrap the code in these routes in a mongodb transactions to make sure the group is always updated correctly. See https://mongoosejs.com/docs/transactions.html for a guide on how to use transactions
|
Closing this PR as abandoned. @lsophie, if you end up circling back to this, please comment on the associated issue ticket noting that you're taking it up! |
SabreCat
added
status: pr: abandoned
and removed
status: pr: with author: needs work
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12286
Changes
Recomputes
memberCountusing mongoDB transactions each time it needs to be updated for both Parties and Guilds (was previously only done for Parties). This change is reflected inwebsite/server/controllers/api-v3/groups.js.Changes to
.vuefiles were done automatically after runningnpm run lint.UUID: ddd2399a-30f0-4b6a-a2f6-d6731f4621c7