-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intro guide #15247
base: develop
Are you sure you want to change the base?
Fix intro guide #15247
Conversation
@SabreCat Can you review this? Thanks! |
This is awesome! I've encountered this issue a couple of times but never found any clue how to fix that, and here you are with a fix 👏 👏 well done!! @SabreCat LGTM and tested locally 🎉 |
@negue Thanks, your comment made my day. |
What I find weird is that this issue is only while in dev mode, on the production build this jquery issue never happens I don't see any reason not to use your fix, one issue less to see while working in dev mode ^^ |
@nague In production, this error also occurs, and the introduction is not showing. It's just that in production mode, runtime errors are not displayed on the screen, but you will see the same error in the console. This error, of course, disappears when you have unlocked all guide steps. |
I've tested this locally and the error in dev no longer occurs. @SabreCat, looks like it's ready for code review! |
Fixes intro guide error "invalid instaceof window.jquery"
Changes in client/vue.config.js
const webpackPlugins = [ + new webpack.ProvidePlugin({'window.jQuery': 'jquery'}), new webpack.DefinePlugin(envObject), new webpack.ContextReplacementPlugin(/moment[\\/]locale$/, /^\.\/(NOT_EXISTING)$/), ];
Error code: https://gist.github.com/rafJagCode/609d8773dc553cdfad9d4cb50ecc4124
Error img before fix and intro guide displayed after providing window.jquery:
UUID: 01148fda-c7f3-4668-a83d-e519eaf9407c