Repository navigation
Added Slack notifications for mentorships - #461
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues with the mentorship and check-in notification changes.
No open issues 🎉
What changed in this PR
Extends Dojo’s Slack notifications to mentorship creation and check-ins, including profile links and reporter attribution while keeping check-in notes private.
Changes:
- Adds mentorship and check-in notifications with participant links and dates.
- Passes the authenticated user through create endpoints and distinguishes existing interaction notification headings.
- Adds tests for notification content and exclusion of check-in notes, using mocked Slack delivery.
| File | Description |
|---|---|
server-spring/src/test/java/nl/hackyourfuture/dojoserver/mentorship/MentorshipTest.java |
Tests mentorship notifications with an authenticated reporter. |
server-spring/src/test/java/nl/hackyourfuture/dojoserver/mentorship/checkin/MentorshipCheckinTest.java |
Tests check-in notifications and exclusion of private notes. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/slack/SlackNotificationSender.java |
Formats new notifications and clarifies interaction headings. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/MentorshipService.java |
Sends a notification when creating a mentorship. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/MentorshipController.java |
Passes the authenticated user to mentorship creation. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/Mentorship.java |
Provides the mentorship profile path for links. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/checkin/MentorshipCheckinService.java |
Loads mentorship details and sends check-in notifications. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/checkin/MentorshipCheckinController.java |
Passes the authenticated user to check-in creation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.