Repository navigation
Added participant field to mentorship checkins - #462
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The check-in list incorrectly attributes staff check-ins to the participant by using “by” instead of “with” in both display branches.
1 open issue
What changed in this PR
Adds participant tracking to mentorship check-ins so staff can record whether they checked in with the mentor or trainee.
Changes:
- Persists and validates the participant, backfilling existing check-ins as mentor check-ins.
- Adds participant selection and display, using first or preferred names in the timeline.
- Updates Slack notifications, setup data, and backend tests.
| File | Description |
|---|---|
server-spring/src/test/java/nl/hackyourfuture/dojoserver/mentorship/MentorshipTest.java |
Tests first-name and preferred-name responses. |
server-spring/src/test/java/nl/hackyourfuture/dojoserver/mentorship/checkin/MentorshipCheckinTest.java |
Tests participant persistence, validation, updates, and notifications. |
server-spring/src/main/resources/db/migration/V2__mentorship_checkin_participant.sql |
Adds the required participant column and backfills existing records. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/volunteer/dto/VolunteerReferenceResponse.java |
Exposes volunteer first names. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/trainee/profile/dto/TraineeReferenceResponse.java |
Exposes trainee preferred or first names. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/slack/SlackNotificationSender.java |
Includes participants in check-in notifications. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/checkin/MentorshipCheckinService.java |
Saves participants during creation and updates. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/checkin/MentorshipCheckinParticipant.java |
Defines mentor and trainee participant values. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/checkin/MentorshipCheckin.java |
Maps the participant as a persisted string enum. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/checkin/dto/MentorshipCheckinResponse.java |
Returns the participant in API responses. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/mentorship/checkin/dto/MentorshipCheckinRequest.java |
Requires a participant in API requests. |
scripts/setup/dojo_setup/generators/checkin.py |
Generates sample check-in participants. |
client/src/features/mentorships/Mentorship.ts |
Adds first names to mentorship person references. |
client/src/features/mentorships/checkins/MentorshipCheckins.tsx |
Passes participant names to the timeline and dialog. |
client/src/features/mentorships/checkins/MentorshipCheckinParticipant.ts |
Defines client participant values. |
client/src/features/mentorships/checkins/MentorshipCheckin.ts |
Adds the participant to the domain model. |
client/src/features/mentorships/checkins/components/MentorshipCheckinsList.tsx |
Displays participant names and roles. |
client/src/features/mentorships/checkins/components/MentorshipCheckinDialog.tsx |
Adds required participant selection. |
client/src/features/mentorships/checkins/api/types.ts |
Adds the participant to API types. |
client/src/features/mentorships/checkins/api/mapper.ts |
Maps participants between API and domain models. |
client/src/features/mentorships/api/types.ts |
Adds first names to API person references. |
client/src/features/mentorships/api/mapper.ts |
Maps first names into mentorship references. |
Review effort: Balanced
stasel
force-pushed
the
mentorship-checkin-participant
branch
from
November 10, 2026 14:09
8f0ee1f to
0a444c7
Compare
stasel
force-pushed
the
mentorship-checkin-participant
branch
from
November 10, 2026 14:20
0a444c7 to
1ea8c0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.