Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Enable anti cheat runtimes by default #3103

Merged
merged 10 commits into from
Nov 21, 2023
Merged

[FIX] Enable anti cheat runtimes by default #3103

merged 10 commits into from
Nov 21, 2023

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Oct 1, 2023 •
edited
Loading

This is probably the best way to do it, rather than just reading the anticheat data. Proton does the same thing for most titles I think

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Nocccer
Nocccer reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it does not use more free space on each game we could enable it always. How big are this runtimes and are they copied over to the prefix?

src/backend/config.ts Show resolved Hide resolved
@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Oct 2, 2023 •
edited
Loading

As long as it does not use more free space on each game we could enable it always. How big are this runtimes and are they copied over to the prefix?

It doesn't take any additional storage, nothing is copied to the prefix

@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 21, 2023
@Etaash-mathamsetty
Copy link
Member Author

updated to automatically download the runtimes as well

@arielj arielj added this to the 2.10.0 milestone Oct 28, 2023
Etaash-mathamsetty
Etaash-mathamsetty commented Oct 28, 2023
View reviewed changes
src/backend/config.ts
@@ -323,7 +324,9 @@ class GlobalConfigV0 extends GlobalConfig {
winePrefix: isWindows ? '' : defaultWinePrefix,
wineVersion: defaultWine,
enableEsync: true,
enableFsync: true
enableFsync: isLinux,
Copy link
Member Author

@Etaash-mathamsetty Etaash-mathamsetty Oct 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fsync uses a linux specific syscall and can only should be enabled by default on linux

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be nitpicky, but I don't think this should be in this PR

arielj
arielj reviewed Oct 31, 2023
View reviewed changes
src/backend/launcher.ts Outdated
}

if (gameSettings.battlEyeRuntime && !isInstalled('battleye_runtime')) {
download('battleye_runtime')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we await these calls? so we don't launch the game before they are downloaded

also, should we handle the case when something fails to download? like no internet connection for example, since I understand that setting to true when it's not available is a problem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree on that as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are offline then the anti cheat not running doesn't matter in most cases right?

CommandMC
CommandMC previously requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also have to auto-enable GameMode if we're on Flatpak

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Nov 7, 2023 •
edited
Loading

You'll also have to auto-enable GameMode if we're on Flatpak

is gamemode is always installed on the flaptak?

@CommandMC
Copy link
Collaborator

Yes, the Flatpak always installs it. See com.heroicgameslauncher.hgl.yml#L111

kohend
kohend approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@kohend kohend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@flavioislima flavioislima merged commit 6b430d8 into Heroic-Games-Launcher:main Nov 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nocccer Nocccer Nocccer left review comments

@arielj arielj arielj left review comments

@flavioislima flavioislima flavioislima approved these changes

@kohend kohend kohend approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Etaash-mathamsetty @CommandMC @arielj @kohend @flavioislima @Nocccer