Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Remember last url opened in the webview, reopen there #3149

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 21, 2023

This PR fixes #758

Now the last url that we navigate to in the webview is remembered and used when clicking the stores icon in the sidebar.

Users can still navigate to any of the stores with the sidebar submenu or the game's Store page links.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 21, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team October 21, 2023 04:38
@flavioislima
Copy link
Member

Tested here and works just fine, except for the item on the sidebar that it is not changing based on the URL, I mean, it does not show as selected:

image

@flavioislima
Copy link
Member

Another idea that could improve this would be to store the last URL per store instead of the whole webview.
This is useful when we are getting the free games from Amazon prime that sometimes includes GOG games that requires going to the GOG store and redeem the code.

@arielj
Copy link
Collaborator Author

arielj commented Oct 27, 2023

@flavioislima can you check again? I updated the code to show the current store in the sidebar and to store the last url for each store independently

@flavioislima
Copy link
Member

@flavioislima can you check again? I updated the code to show the current store in the sidebar and to store the last url for each store independently

I will check earlier in the morning! 👍

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works amazingly well now! :D

@flavioislima flavioislima merged commit 41595f3 into main Oct 27, 2023
13 checks passed
@flavioislima flavioislima deleted the remember-last-store-url branch October 27, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Don't always start store at Epic's home page
2 participants