Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Legendary. Replace XDG_CONFIG_HOME variable. Disallow uninstalling epic game if installing one #3168

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 28, 2023

This PR is a replacement of #2806 and #3137

It includes the update of Legendary and the change to use the LEGENDARY_CONFIG_PATH env variable and also adds the dialog that disallows users from uninstalling an Epic game while an Epic game is being installed since that's not possible with the latest Legendary.

cc @Etaash-mathamsetty and @CommandMC

Screenshot 2023-10-28 at 4 34 42 PM

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 28, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team October 28, 2023 19:36
@arielj arielj added this to the 2.10.0 milestone Oct 28, 2023
@flavioislima
Copy link
Member

I am fine with this solution for now.
Although we should think on improving it in the future maybe having more control over the epic games and using legendary mostly to download the games itself, but with Heroic handling the install.json file.
I know there is a way of only downloading the game with it so this way Heroic would handle both installing and uninstalling.

@flavioislima
Copy link
Member

Tested here and everything seems to works fine.

@flavioislima flavioislima merged commit 896a396 into main Oct 29, 2023
13 checks passed
@flavioislima flavioislima deleted the lgndry-update branch October 29, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants