Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 27: more fixes (gallery lazy load) #3170

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Electron 27: more fixes (gallery lazy load) #3170

merged 1 commit into from
Oct 29, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 29, 2023

After using the latest main with Electron 27 I noticed the library felt slow and it was because the lazy loading of the elements below the fold broke with all the changes related to which element is the scroll element.

This PR fixes that to render it fast again.

I also removed a leftover console.log.

I'll keep testing to see if I find any other issue.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 29, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team October 29, 2023 15:06
@arielj arielj added this to the 2.10.0 milestone Oct 29, 2023
flavioislima
flavioislima approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima merged commit 15c4351 into main Oct 29, 2023
13 checks passed
@flavioislima flavioislima deleted the more-electron-27-fixes branch October 29, 2023 18:34
@arielj arielj mentioned this pull request Oct 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arielj @flavioislima