[Fix] Prevent useEffect infinite loops

[arielj]

This PR fixes a problem I noticed in some components in the Advanced screen that include the state variable as a dependency for useEffects that update that state. This can lead to infinite loops and it's not correct to do it.

This can be seen when running a clean install of Heroic and going to Settings > Advanced, there's an infinite loop in the dev tools console.

This is solved once the experimental features are modified, but we shouldn't have this loop to begin with.

The useEffect that updates the Copy to clipboard status is safe because it returns early if false so it doesn't call a state setter.

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[CommandMC]

Almost like someone didn't know how React worked back when they wrote this code (to clarify, this "someone" was me)

Thanks!

[flavioislima]

Almost like someone didn't know how React worked back when they wrote this code (to clarify, this "someone" was me)

Thanks!

no worries about that, I also did this mistake a few times 👍🏽

[flavioislima]

Good catch!