[Tech] Refactor Extraction methods #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
requested review from
CommandMC,
arielj,
Etaash-mathamsetty,
Nocccer and
imLinguin
flavioislima
added
the
pr:ready-for-review
12 tasks
flavioislima
added a commit
that referenced
this pull request
Mar 31, 2024
flavioislima
added a commit
that referenced
this pull request
Aug 9, 2024
* [Revert] Refactor Extraction methods #3181 * Tech/upstream electron (#3664) * chore: yarn.lock * [TECH] Revert Electron to Upstream * chore: Remove unused import in main.ts --------- Co-authored-by: Flavio F Lima <[email protected]> * chore: pnpm-lock * fix: codecheck * tests: remove unused packages * chore: remove mock for decompress in compatibility_layers.test.ts * chore: pr comments * Consolidate tar file extraction into one function again (#3909) --------- Co-authored-by: Flavio F Lima <[email protected]> Co-authored-by: Mathis Dröge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to use system
tarcommands for extracting tools like dxvk, wine, proton, etc.This way Heroic does not depend on the availability of these tools on the system, especially on Snaps which does not support tar.xz by default.
It also opens the possibility of supporting ZSTD files natively if we want to, we just need to install the plugin for this in case we need it: https://www.npmjs.com/package/@xingrz/decompress-tarzst
Use the following Checklist if you have changed something on the Backend or Frontend: