Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Wine Stuck sometimes at adding registry key #3210

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented Nov 5, 2023

Otherwise, newer Wine versions will prompt to overwrite it and loop there forever.

<--- Put the description here --->


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Otherwise, newer Wine versions will prompt to overwrite it and loop there forever.
@arielj
Copy link
Collaborator

arielj commented Nov 5, 2023

can you explain the problem better? how can this be reproduced?

@K900
Copy link
Contributor Author

K900 commented Nov 5, 2023

I'm not entirely sure how it can be reproduced - it happens consistently on some of my existing Wine prefixes, but not new ones. Basically, the reg add command will just get stuck. straceing it shows it gets stuck on an "overwrite? [yes/no]" prompt, which can be bypassed with /f.

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Nov 5, 2023

I'm not entirely sure how it can be reproduced - it happens consistently on some of my existing Wine prefixes, but not new ones. Basically, the reg add command will just get stuck. straceing it shows it gets stuck on an "overwrite? [yes/no]" prompt, which can be bypassed with /f.

that means that the registry key is already there, which is a strange, but I don't see any problem with adding a /f here.
so easiest way to reproduce is to add the registry key before legendarySetup is run, I have no idea how this would happen during normal operation, but it is what it is I guess.

@K900
Copy link
Contributor Author

K900 commented Nov 6, 2023

Not really sure why the CI failed here, but seems unrelated?

@flavioislima flavioislima changed the title Force add the registry entry [FIX] Wine Stuck sometimes at adding registry key Nov 6, 2023
@Etaash-mathamsetty Etaash-mathamsetty merged commit 75c72c4 into Heroic-Games-Launcher:main Nov 6, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants