Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our E2E test configuration, while being very robust, was a bit overkill for what we're doing with it. Instead of running the tests in a Docker container to isolate them, we can simply set Heroic's configuration directory to a temporary one. In addition, the "packaged" and "dev" tests only differ slightly (one having Heroic's code in the
build
directory, while the other has it zipped up in a single file somewhere indist
), but this difference is not significant enough to warrant two separate test runs IMOI hope that by making it easier to run these tests, we can start to use them properly in the future
Use the following Checklist if you have changed something on the Backend or Frontend: