-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs] Add more info in game logs #3394
Conversation
join(legendaryConfigPath, 'overlay_version.json') | ||
const installedVersionPath = () => | ||
join(legendaryConfigPath, 'overlay_install.json') | ||
const defaultInstallPath = () => join(toolsPath, 'eos_overlay') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved these consts into functions to avoid an import loop
if (!gameInfo) { | ||
logError([`Could not find game info for ${appName}. Skipping setup`]) | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't run setup steps if we can't find game info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fixes #3187, and fixes #3186 and fixes #3104
This PR adds more information in the logs to make them more useful when users share them over Discord.
New info:
===== End of game logs =====
line at the end so we know users didn't cut log when sharingI also included a few extra changes that I needed:
The log now looks like this:
Use the following Checklist if you have changed something on the Backend or Frontend: