Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs] Log installed Winetricks packages when launching game #3516

Closed
wants to merge 3 commits into from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 4, 2024

Before the previous release I had to rever this change because calling winetricks before the wineprefix was ready was creating insues.

This PR fixes that by only logging Winetricks packages if the wine prefix was created successfully.

I added the afterInit async callback so it can be printed at the right position of the logs and still be async.

Fixes #3104


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 4, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team February 4, 2024 04:16
@flavioislima flavioislima added this to the 2.13.0 milestone Feb 4, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arielj
Copy link
Collaborator Author

arielj commented Feb 4, 2024

I'm closing this, I did some more testing and it's till not working as expected.

I mixed the function that checks if the wine config is a valid wine with the function that sets up the prefix which happens later.

I'll work on this at another time, I'll close this for now.

@arielj arielj closed this Feb 4, 2024
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List components installed with Winetricks in logs
2 participants