Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Disable import button when invalid flatpak path #4070

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Fix] Disable import button when invalid flatpak path #4070

wants to merge 3 commits into from

Conversation

Etaash-mathamsetty
Copy link
Member

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

CommandMC
CommandMC reviewed Nov 1, 2024
View reviewed changes
src/backend/main.ts Outdated Show resolved Hide resolved
src/backend/main.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused as to why moveInstall is touched here. The "Choosing a path for the imported game install" logic happens solely in the frontend (see src/frontend/helpers/library.ts#84)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommandMC CommandMC CommandMC left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Etaash-mathamsetty @CommandMC